Skip to content

test xcode 26 beta 4 #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test xcode 26 beta 4 #9703

wants to merge 2 commits into from

Conversation

vashworth
Copy link
Contributor

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 30, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates CI configurations for a new Xcode version. However, the PR description is not filled out, which violates the repository's contribution guidelines. Please fill out the template to explain the changes and their purpose. There are also a few issues with the changes themselves. The iOS simulator version is likely incorrect, which could cause CI failures. Additionally, a new flag to allow warnings in the podspec check should be tracked with a TODO to ensure it's a temporary measure.

.ci/scripts/create_simulator.sh
@@ -9,7 +9,7 @@ set -o pipefail
# The name here must match remove_simulator.sh
readonly DEVICE_NAME=Flutter-iPhone
readonly DEVICE=com.apple.CoreSimulator.SimDeviceType.iPhone-14
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-18-2
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-26-0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The iOS simulator runtime version iOS-26-0 appears to be incorrect, as there is no public iOS version 26. This is likely a typo and should probably be iOS-18-0 to align with Xcode 16 beta. An incorrect runtime version will cause CI builds to fail.

Suggested change
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-26-0
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-18-0

packages/pigeon/tool/shared/test_suites.dart
Comment on lines +330 to +331
const String deviceRuntime = 'com.apple.CoreSimulator.SimRuntime.iOS-26-0';
const String deviceOS = '26.0';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The iOS simulator runtime and OS versions appear to be incorrect. There is no public iOS 26.0. This is likely a typo and should probably be iOS-18-0 and 18.0 respectively, to align with Xcode 16 beta. Using an invalid runtime will cause CI failures.

  const String deviceRuntime = 'com.apple.CoreSimulator.SimRuntime.iOS-18-0';
  const String deviceOS = '18.0';

script/tool/lib/src/podspec_check_command.dart
@@ -159,6 +159,7 @@ class PodspecCheckCommand extends PackageLoopingCommand {
podspecPath,
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
'--skip-tests',
'--allow-warnings',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding --allow-warnings can hide legitimate issues introduced by the new SDK. While it can be a temporary measure to unblock CI, this should be tracked to ensure the underlying warnings are eventually fixed and this flag is removed. Please add a TODO comment to track this.

@jmagman
Copy link
Member

jmagman commented Aug 1, 2025 

Error (Xcode): failed to read asset tags: The command `(cd /Volumes/Work/s/w/ir/x/w/packages/packages/animations/example/ios && /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_17a5285i/XCode.app/Contents/Developer/usr/bin/actool --print-asset-tag-combinations --output-format xml1 /Volumes/Work/s/w/ir/x/w/packages/packages/animations/example/ios/Runner/Assets.xcassets)` exited with status 1. The command's standard output was:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>com.apple.ibtool.errors</key>
	<array>
		<dict>
			<key>description</key>
			<string>Unknown argument '--print-asset-tag-combinations'.</string>
		</dict>
	</array>
</dict>
</plist>

Weird, I'm on 17A5285i and that command works for me, I don't get Unknown argument.

$ cd packages/packages/animations/example/ios
$ xcrun actool --print-asset-tag-combinations --output-format xml1 ~/Projects/packages/packages/animations/example/ios/Runner/Assets.xcassets
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>com.apple.actool.asset-tag-combinations</key>
	<array/>
</dict>
</plist>

@jmagman jmagman mentioned this pull request Aug 4, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal will be requested when the pull request is marked ready for review tarrinneal is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
p: pigeon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vashworth @jmagman